Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mocking nullable return types for 7.1 #664

Merged
merged 2 commits into from
Jan 6, 2017

Conversation

shieldo
Copy link
Contributor

@shieldo shieldo commented Jan 6, 2017

Port/ cherry-pick of e393e24 (allowing nullable return types for PHP 7.1) to the 0.9 branch. Also includes support for using the self keyword in a return type.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.523% when pulling 56badcc on shieldo:nullable_return_types_in_09 into 4de7969 on padraic:0.9.

@GrahamCampbell
Copy link
Contributor

I think this was intentionally not put on 0.9, because new features need to go to 1.0?

@davedevelopment
Copy link
Collaborator

@GrahamCampbell I just haven't been bothering with 0.9, happy for others to make contributions if they want to stick with the tagged releases.

This will need updating to exclude the ::class syntax to pass on 5.4 etc

@shieldo
Copy link
Contributor Author

shieldo commented Jan 6, 2017

Yeah I'd suggest this isn't a "new feature" per se as it's just keeping equivalent feature parity (i.e. expecting mocking to work no matter the type declarations) with a new version of PHP without dropping anything older.

Will fix up the tests re the ::class syntax.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.523% when pulling 803019b on shieldo:nullable_return_types_in_09 into 4de7969 on padraic:0.9.

@davedevelopment davedevelopment merged commit d89523a into mockery:0.9 Jan 6, 2017
@davedevelopment
Copy link
Collaborator

Thanks!

@shieldo shieldo deleted the nullable_return_types_in_09 branch January 6, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants