Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer does not inform about permission errors #29

Closed
maxandersen opened this issue May 24, 2023 · 1 comment
Closed

installer does not inform about permission errors #29

maxandersen opened this issue May 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maxandersen
Copy link
Contributor

when installing I get these options:

[1] /Users/manderse/Library/Jupyter/kernels
[2] /usr/local/share/jupyter/kernels
[3] /usr/share/jupyter/kernels

if I pick 3 it goes ahead and setup:

Installation path: /usr/share/jupyter/kernels
Kernel dir: rapaio-jupyter-kernel
kernel.json:
{
  "argv": [
    "java",
    "--enable-preview",
    "-jar",
    "/usr/share/jupyter/kernels/rapaio-jupyter-kernel/rapaio-jupyter-kernel-1.0.1.jar",
    "{connection_file}"
  ],
  "display_name": "Rapaio Kernel",
  "language": "java",
  "interrupt_mode": "message",
  "env": {
    "RJK_COMPILER_OPTIONS": "",
    "RJK_INIT_SCRIPT": "",
    "RJK_TIMEOUT_MILLIS": "-1"
  }
}

but that file does not exist as user does not have permission to write to that directory.

the installer does not complain at all about it. it should :)

@padreati padreati added the bug Something isn't working label May 24, 2023
@padreati
Copy link
Owner

I have tested the same scenario, but I receive a different message.

I have selected also [3] and it displays a similar message like in your case:

Installation path: /usr/share/jupyter/kernels
Kernel dir: rapaio-jupyter-kernel
kernel.json: 
{
  "argv": [
    "java",
    "--enable-preview",
    "-jar",
    "/usr/share/jupyter/kernels/rapaio-jupyter-kernel/rapaio-jupyter-kernel.jar",
    "{connection_file}"
  ],
  "display_name": "Rapaio Kernel",
  "language": "java",
  "interrupt_mode": "message",
  "env": {
    "RJK_COMPILER_OPTIONS": "",
    "RJK_INIT_SCRIPT": "",
    "RJK_TIMEOUT_MILLIS": "-1"
  }
}

The intention is to show the user what the installer will do: where it will be installed, which will be the kernel directory and which will be the content of kernel.json. It does nothing yet. The next displayed text is:

Installer is ready. Do you want to continue [Y/N] ?

If the answer is not capital Y then the installer will quit. (I will improve this behavior in order to tell the user that
the installation was canceled due to not receiving capital Y. Right now it quits quietly, which is a customer bad experience.)

In my case if I continue with capital Y I receive:

Could not create installation directory.

Again, this message looks incomplete, I will improve it with another one like: "Could not create installation directory. Check if it is a valid path or there are enough permissions."

That being said, is there a possibility to push another key other than capital Y? If this is not the case, can you provide me with other details, like do you use a SecurityManager? I know that security manager was deprecated in Java 17 and it will be removed, but I can invest in that if is needed.

@padreati padreati self-assigned this May 24, 2023
@padreati padreati added this to the 1.1.0 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants