New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Padrino.root instead of File.expand_path in apps.rb? #1129

Closed
skade opened this Issue Mar 17, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@skade
Member

skade commented Mar 17, 2013

Sorry for the last-minute ticket, but I was just writing something about the generator changes and found the following:

Padrino.mount('Gemified::App', :app_file => File.expand_path('../../app/app.rb', __FILE__)).to('/')

Wouldn't Padrino.root and MyProject.root (given a gemified app) be more clear and explicit?

@achiu achiu closed this in f8650cb Mar 17, 2013

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Mar 17, 2013

Member

@skade yes nice catch, its much cleaner this way. Thanks!

Member

achiu commented Mar 17, 2013

@skade yes nice catch, its much cleaner this way. Thanks!

achiu added a commit that referenced this issue Mar 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment