New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rack-protection should be configured with a logger #1236

Closed
skade opened this Issue Apr 9, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@skade
Member

skade commented Apr 9, 2013

Currently, rack-protection silently denys access. Instead, we should pass in our logger to log these failures.

See:

https://github.com/rkh/rack-protection/blob/master/lib/rack/protection/base.rb#L59

for reference.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Apr 9, 2013

Member

Awesome, yeah I think this will make a big difference in people's confusion around csrf

Member

nesquena commented Apr 9, 2013

Awesome, yeah I think this will make a big difference in people's confusion around csrf

@basex

This comment has been minimized.

Show comment
Hide comment
@basex

basex Apr 10, 2013

Contributor

Great :) Took me a bit to understand why some posts were being denied.

Contributor

basex commented Apr 10, 2013

Great :) Took me a bit to understand why some posts were being denied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment