Skip to content

rack-protection should be configured with a logger #1236

Closed
skade opened this Issue Apr 9, 2013 · 2 comments

3 participants

@skade
Padrino Framework member
skade commented Apr 9, 2013

Currently, rack-protection silently denys access. Instead, we should pass in our logger to log these failures.

See:

https://github.com/rkh/rack-protection/blob/master/lib/rack/protection/base.rb#L59

for reference.

@nesquena
Padrino Framework member
nesquena commented Apr 9, 2013

Awesome, yeah I think this will make a big difference in people's confusion around csrf

@basex
basex commented Apr 10, 2013

Great :) Took me a bit to understand why some posts were being denied.

@dariocravero dariocravero pushed a commit that closed this issue Apr 11, 2013
Darío Javier Cravero Pass our logger to rack-protection. Fixes #1236. 39fc7f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.