New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have padrino start eval config.ru #1260

Closed
postmodern opened this Issue Apr 26, 2013 · 10 comments

Comments

Projects
None yet
5 participants
@postmodern
Contributor

postmodern commented Apr 26, 2013

I feel that any code included in config.ru should be ran when running the app in development mode.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Apr 26, 2013

Contributor

Mmm, I don't know about that @postmodern. The way I see it, config.ru is there for rackup to pick it up and for application servers to work properly.
What are you trying to achieve? Maybe config/boot.rb or config/apps.rb are a better fit?

Contributor

dariocravero commented Apr 26, 2013

Mmm, I don't know about that @postmodern. The way I see it, config.ru is there for rackup to pick it up and for application servers to work properly.
What are you trying to achieve? Maybe config/boot.rb or config/apps.rb are a better fit?

@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern Apr 26, 2013

Contributor

I was thinking of adding middleware to config.ru so that it would run before Padrino's middleware.

Contributor

postmodern commented Apr 26, 2013

I was thinking of adding middleware to config.ru so that it would run before Padrino's middleware.

@christhekeele

This comment has been minimized.

Show comment
Hide comment
@christhekeele

christhekeele Apr 26, 2013

@postmodern
What you're really looking for, I feel, is something like foreman.

christhekeele commented Apr 26, 2013

@postmodern
What you're really looking for, I feel, is something like foreman.

@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern Apr 26, 2013

Contributor

Just trying to use a middleware before Padrino's own middleware, in particular Rack::Protection::AuthenticityToken.

Contributor

postmodern commented Apr 26, 2013

Just trying to use a middleware before Padrino's own middleware, in particular Rack::Protection::AuthenticityToken.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Apr 26, 2013

Contributor

@postmodern and why don't you just ran your app using rackup instead of padrino start? It's virtually the same thing :)

Contributor

dariocravero commented Apr 26, 2013

@postmodern and why don't you just ran your app using rackup instead of padrino start? It's virtually the same thing :)

@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern Apr 26, 2013

Contributor

rackup doesn't do reloading, also I could see it confusing developers.

Contributor

postmodern commented Apr 26, 2013

rackup doesn't do reloading, also I could see it confusing developers.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Apr 26, 2013

Member

@postmodern For now, you can use Padrino.use for that, which puts things in front of the whole Padrino stack.

I do, however, get this request quite often and I think its reasonable, because it makes all environments behave the same.

Member

skade commented Apr 26, 2013

@postmodern For now, you can use Padrino.use for that, which puts things in front of the whole Padrino stack.

I do, however, get this request quite often and I think its reasonable, because it makes all environments behave the same.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Apr 26, 2013

Contributor

@skade should we plan this for 0.12 maybe?

Contributor

dariocravero commented Apr 26, 2013

@skade should we plan this for 0.12 maybe?

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Apr 26, 2013

Member

Not earlier, it might surprise people.

Member

skade commented Apr 26, 2013

Not earlier, it might surprise people.

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jul 1, 2013

Member

@skade can u work on this?

Member

DAddYE commented Jul 1, 2013

@skade can u work on this?

@ghost ghost assigned skade Jul 1, 2013

@ujifgc ujifgc closed this in 1e4ce6e Feb 18, 2014

ujifgc added a commit that referenced this issue Feb 18, 2014

Merge pull request #1597 from padrino/1260-eval-config
load config.ru with padrino server, fixes #1260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment