New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio_button_group not .html_safe? #1283

Closed
shipstar opened this Issue May 9, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@shipstar

shipstar commented May 9, 2013

I added a radio_button_group to a form like so (Slim):

= f.radio_button_group :foo, options: ['bar', 'baz']

It generates the correct HTML, but it renders as a String:

<label for="rsvp_foo_bar"><input value="bar" id="rsvp_foo_bar" name="rsvp[foo]" type="radio" /> bar</label><label for="rsvp_foo_baz"><input value="baz" id="rsvp_foo_baz" name="rsvp[foo]" type="radio" /> baz</label>

If I wrap it with ( ).html_safe, it displays as expected.

I'm running against gem 'padrino', :github => 'padrino/padrino-framework'

@ujifgc ujifgc closed this in 00181d2 May 10, 2013

WaYdotNET added a commit to WaYdotNET/padrino-framework that referenced this issue May 15, 2013

Merge remote-tracking branch 'upstream/master' into refresh-admin
* upstream/master: (21 commits)
  Side stepped rack-test limitations with non-ASCII
  Added monkey patch to http_router to handle utf-8 chars
  Reproduced same error
  typo fix
  Added test and UTF encoding
  Lock minitest version from going to 5
  Fixed warning, minitest/autorun should be required first
  fixes #1283
  fix test suite to catch non-safe html
  fixes #1274, fixes #1269
  Double quote replacement
  Formated text + single quote replacement
  Removed newline
  Removed unused smtp_settings variable
  Typo fixe + license year removal
  Fixed encoding parameter in Rakefile
  Removed Java like comment style
  Fixed intendation, and punctuation mark
  Typo fixes and intendation of private method block
  Remove tilt comment
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment