New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default layout is not applied since commit f7b71b2 on mingw32 #1624

Closed
tune opened this Issue Mar 13, 2014 · 9 comments

Comments

Projects
None yet
2 participants
@tune

tune commented Mar 13, 2014

I've found that default layout template (like views/layouts/application.haml) is not applied since commit f7b71b2.

Is this a bug, or do I need to set something newly?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 13, 2014

Member

Sounds like a bug.

Member

ujifgc commented Mar 13, 2014

Sounds like a bug.

@ujifgc ujifgc added bug and removed blocker labels Mar 13, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 13, 2014

Member

The default location of layouts is views/layouts, not in views/layout. Please reopen with an example of failing project if the problem persists.

Member

ujifgc commented Mar 13, 2014

The default location of layouts is views/layouts, not in views/layout. Please reopen with an example of failing project if the problem persists.

@ujifgc ujifgc closed this Mar 13, 2014

@tune

This comment has been minimized.

Show comment
Hide comment
@tune

tune Mar 14, 2014

The default location of layouts is views/layouts, not in views/layout.

Sorry, it's typo.

I've prepared sample program to reproduce this problem.
Please clone tune/padrino_sample and checkout bug/1624 branch.

The difference of commit 74efa620d is only padrino version, but views/layouts/application.haml is not applied in problem version.

tune commented Mar 14, 2014

The default location of layouts is views/layouts, not in views/layout.

Sorry, it's typo.

I've prepared sample program to reproduce this problem.
Please clone tune/padrino_sample and checkout bug/1624 branch.

The difference of commit 74efa620d is only padrino version, but views/layouts/application.haml is not applied in problem version.

@tune

This comment has been minimized.

Show comment
Hide comment
@tune

tune Mar 14, 2014

I couldn't change issue status to reopen, so can somebody help me?

tune commented Mar 14, 2014

I couldn't change issue status to reopen, so can somebody help me?

@ujifgc ujifgc reopened this Mar 14, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 14, 2014

Member

What exactly is not working? On both versions and on padrino edge I get

inside application.haml

inside index.haml 

when I enter http://localhost/index

Member

ujifgc commented Mar 14, 2014

What exactly is not working? On both versions and on padrino edge I get

inside application.haml

inside index.haml 

when I enter http://localhost/index

@tune

This comment has been minimized.

Show comment
Hide comment
@tune

tune Mar 14, 2014

In my environment, only "inside index.haml" is displayed.

% ruby -v
ruby 2.0.0p247 (2013-06-27) [i386-mingw32]
GIT
  remote: https://github.com/padrino/padrino-framework.git
  revision: f7b71b266b1f25a456c477c5da52f57585c83364
  ref: f7b71b266b1f25a456c477c5da52f57585c83364
  specs:
    padrino (0.12.0)
      padrino-admin (= 0.12.0)
      padrino-cache (= 0.12.0)
      padrino-core (= 0.12.0)
      padrino-gen (= 0.12.0)
      padrino-helpers (= 0.12.0)
      padrino-mailer (= 0.12.0)
      padrino-support (= 0.12.0)
    padrino-admin (0.12.0)
      padrino-core (= 0.12.0)
      padrino-helpers (= 0.12.0)
    padrino-cache (0.12.0)
      moneta (~> 0.7.0)
      padrino-core (= 0.12.0)
      padrino-helpers (= 0.12.0)
    padrino-core (0.12.0)
      activesupport (>= 3.1)
      http_router (~> 0.11.0)
      padrino-support (= 0.12.0)
      rack-protection (>= 1.5.0)
      sinatra (~> 1.4.2)
      thor (~> 0.18.0)
      tilt (~> 1.4.1)
    padrino-gen (0.12.0)
      bundler (~> 1.0)
      padrino-core (= 0.12.0)
    padrino-helpers (0.12.0)
      i18n (~> 0.6, >= 0.6.7)
      padrino-support (= 0.12.0)
    padrino-mailer (0.12.0)
      mail (~> 2.5.3)
      padrino-core (= 0.12.0)
    padrino-support (0.12.0)
      activesupport (>= 3.1)

GEM
  remote: https://rubygems.org/
  specs:
    activesupport (4.0.3)
      i18n (~> 0.6, >= 0.6.4)
      minitest (~> 4.2)
      multi_json (~> 1.3)
      thread_safe (~> 0.1)
      tzinfo (~> 0.3.37)
    atomic (1.1.15)
    haml (4.0.5)
      tilt
    http_router (0.11.1)
      rack (>= 1.0.0)
      url_mount (~> 0.2.1)
    i18n (0.6.9)
    mail (2.5.4)
      mime-types (~> 1.16)
      treetop (~> 1.4.8)
    mime-types (1.25.1)
    minitest (4.7.5)
    moneta (0.7.20)
    multi_json (1.9.0)
    polyglot (0.3.4)
    rack (1.5.2)
    rack-protection (1.5.2)
      rack
    rake (10.1.1)
    sinatra (1.4.4)
      rack (~> 1.4)
      rack-protection (~> 1.4)
      tilt (~> 1.3, >= 1.3.4)
    thor (0.18.1)
    thread_safe (0.2.0)
      atomic (>= 1.1.7, < 2)
    tilt (1.4.1)
    treetop (1.4.15)
      polyglot
      polyglot (>= 0.3.1)
    tzinfo (0.3.39)
    url_mount (0.2.1)
      rack

PLATFORMS
  x86-mingw32

DEPENDENCIES
  haml
  padrino!
  rake

tune commented Mar 14, 2014

In my environment, only "inside index.haml" is displayed.

% ruby -v
ruby 2.0.0p247 (2013-06-27) [i386-mingw32]
GIT
  remote: https://github.com/padrino/padrino-framework.git
  revision: f7b71b266b1f25a456c477c5da52f57585c83364
  ref: f7b71b266b1f25a456c477c5da52f57585c83364
  specs:
    padrino (0.12.0)
      padrino-admin (= 0.12.0)
      padrino-cache (= 0.12.0)
      padrino-core (= 0.12.0)
      padrino-gen (= 0.12.0)
      padrino-helpers (= 0.12.0)
      padrino-mailer (= 0.12.0)
      padrino-support (= 0.12.0)
    padrino-admin (0.12.0)
      padrino-core (= 0.12.0)
      padrino-helpers (= 0.12.0)
    padrino-cache (0.12.0)
      moneta (~> 0.7.0)
      padrino-core (= 0.12.0)
      padrino-helpers (= 0.12.0)
    padrino-core (0.12.0)
      activesupport (>= 3.1)
      http_router (~> 0.11.0)
      padrino-support (= 0.12.0)
      rack-protection (>= 1.5.0)
      sinatra (~> 1.4.2)
      thor (~> 0.18.0)
      tilt (~> 1.4.1)
    padrino-gen (0.12.0)
      bundler (~> 1.0)
      padrino-core (= 0.12.0)
    padrino-helpers (0.12.0)
      i18n (~> 0.6, >= 0.6.7)
      padrino-support (= 0.12.0)
    padrino-mailer (0.12.0)
      mail (~> 2.5.3)
      padrino-core (= 0.12.0)
    padrino-support (0.12.0)
      activesupport (>= 3.1)

GEM
  remote: https://rubygems.org/
  specs:
    activesupport (4.0.3)
      i18n (~> 0.6, >= 0.6.4)
      minitest (~> 4.2)
      multi_json (~> 1.3)
      thread_safe (~> 0.1)
      tzinfo (~> 0.3.37)
    atomic (1.1.15)
    haml (4.0.5)
      tilt
    http_router (0.11.1)
      rack (>= 1.0.0)
      url_mount (~> 0.2.1)
    i18n (0.6.9)
    mail (2.5.4)
      mime-types (~> 1.16)
      treetop (~> 1.4.8)
    mime-types (1.25.1)
    minitest (4.7.5)
    moneta (0.7.20)
    multi_json (1.9.0)
    polyglot (0.3.4)
    rack (1.5.2)
    rack-protection (1.5.2)
      rack
    rake (10.1.1)
    sinatra (1.4.4)
      rack (~> 1.4)
      rack-protection (~> 1.4)
      tilt (~> 1.3, >= 1.3.4)
    thor (0.18.1)
    thread_safe (0.2.0)
      atomic (>= 1.1.7, < 2)
    tilt (1.4.1)
    treetop (1.4.15)
      polyglot
      polyglot (>= 0.3.1)
    tzinfo (0.3.39)
    url_mount (0.2.1)
      rack

PLATFORMS
  x86-mingw32

DEPENDENCIES
  haml
  padrino!
  rake
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 14, 2014

Member

Okay, I will check it on windows later today.

Member

ujifgc commented Mar 14, 2014

Okay, I will check it on windows later today.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 14, 2014

Member

Yeah, confirmed on windows

$ ruby -v
ruby 2.0.0p451 (2014-02-24) [i386-mingw32]
Member

ujifgc commented Mar 14, 2014

Yeah, confirmed on windows

$ ruby -v
ruby 2.0.0p451 (2014-02-24) [i386-mingw32]

@ujifgc ujifgc added blocker and removed revalidate labels Mar 14, 2014

@ujifgc ujifgc added this to the 0.12.1 milestone Mar 14, 2014

@ujifgc ujifgc removed the blocker label Mar 17, 2014

@ujifgc ujifgc changed the title from default layout (views/layouts/application.xxx) is not applied since commit f7b71b2 to default layout is not applied since commit f7b71b2 on mingw32 Mar 17, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 18, 2014

Member

Fixed by 8b0b4fa

Member

ujifgc commented Mar 18, 2014

Fixed by 8b0b4fa

@ujifgc ujifgc closed this Mar 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment