New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select_tag outputs value of include_blank into HTML #1646

Closed
tdreyno opened this Issue Apr 4, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@tdreyno

tdreyno commented Apr 4, 2014

Looks like the include_blank key isn't getting removed from the hash before it is passed along to the tag helper.

This must have changed between 0.12.0 and 0.12.1.

Inputs:

<%= select_tag :colors, options: ["red", "blue", "blorange"], include_blank: "Choose a color" %>

0.12.1 output:

    <select name="colors" include_blank="Choose a color"><option value="">Choose a color</option>
    <option value="red">red</option>
    <option value="blue">blue</option>
    <option value="blorange">blorange</option>
    </select>

@ujifgc ujifgc closed this in e57e26e Apr 5, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Apr 5, 2014

Member

Thanks for your report.

Member

ujifgc commented Apr 5, 2014

Thanks for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment