You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before 72acd33, when you call rendering methods (erb, slim, builder and so on) without layout option, Padrino applies a layout only if the template is slim, erb or haml. However, 72acd33 makes Padrino to implicitly apply a layout to other templates (e.g. builder, yajl, rabl), too.
I've just fixed an app which renders an XML document by builder :feed, locals: { articles: articles }. After 72acd33, Padrino implicitly applies a layout for HTML pages (views/layouts/application.slim) to the XML document, and it is broken. I don't think this is the only app affected.
I'm not against this behavior, but want to know if it is intended (by @ujifgc), since the commit message of 72acd33 doesn't mention this breaking change.
The text was updated successfully, but these errors were encountered:
Before 72acd33, when you call rendering methods (
erb
,slim
,builder
and so on) withoutlayout
option, Padrino applies a layout only if the template is slim, erb or haml. However, 72acd33 makes Padrino to implicitly apply a layout to other templates (e.g. builder, yajl, rabl), too.I've just fixed an app which renders an XML document by
builder :feed, locals: { articles: articles }
. After 72acd33, Padrino implicitly applies a layout for HTML pages (views/layouts/application.slim
) to the XML document, and it is broken. I don't think this is the only app affected.I'm not against this behavior, but want to know if it is intended (by @ujifgc), since the commit message of 72acd33 doesn't mention this breaking change.
The text was updated successfully, but these errors were encountered: