New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72acd33 breaks some rendering without `layout` option #1727

Closed
vzvu3k6k opened this Issue Jul 22, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@vzvu3k6k

vzvu3k6k commented Jul 22, 2014

Before 72acd33, when you call rendering methods (erb, slim, builder and so on) without layout option, Padrino applies a layout only if the template is slim, erb or haml. However, 72acd33 makes Padrino to implicitly apply a layout to other templates (e.g. builder, yajl, rabl), too.

I've just fixed an app which renders an XML document by builder :feed, locals: { articles: articles }. After 72acd33, Padrino implicitly applies a layout for HTML pages (views/layouts/application.slim) to the XML document, and it is broken. I don't think this is the only app affected.

I'm not against this behavior, but want to know if it is intended (by @ujifgc), since the commit message of 72acd33 doesn't mention this breaking change.

@ujifgc ujifgc added bug labels Jul 22, 2014

@ujifgc ujifgc self-assigned this Jul 22, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 22, 2014

Member

The change was unintended. Looks like our tests are not strong enough. I will try to fix it. Thank you for the report.

Member

ujifgc commented Jul 22, 2014

The change was unintended. Looks like our tests are not strong enough. I will try to fix it. Thank you for the report.

@ujifgc ujifgc closed this in b0f0b72 Jul 24, 2014

@vzvu3k6k

This comment has been minimized.

Show comment
Hide comment
@vzvu3k6k

vzvu3k6k Jul 24, 2014

Thank you for your speedy response and fix 👍

vzvu3k6k commented Jul 24, 2014

Thank you for your speedy response and fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment