New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padrino-gen controller specs should emit the controller's route, instead of FooController #1765

Closed
postmodern opened this Issue Sep 15, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@postmodern
Contributor

postmodern commented Sep 15, 2014

When one generates a controller with padrino-gen, tests are also generated. When using RSpec, the following test is generated:

require 'spec_helper'

describe "FoosController" do
  before do
    get "/"
  end

  it "returns hello world" do
    last_response.body.should == "Hello World"
  end
end

I think it would be more descriptive if the describe block used the controller's base URL route (ex: /foo) instead of FoosController.

@ujifgc ujifgc added the test label Sep 19, 2014

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 28, 2014

Member

Yeah FoosController doesn't exist in fact, so your suggestion seems reasonable to me.

Member

namusyaka commented Sep 28, 2014

Yeah FoosController doesn't exist in fact, so your suggestion seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment