New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt 2 support #1789

Closed
dariocravero opened this Issue Oct 16, 2014 · 8 comments

Comments

Projects
None yet
6 participants
@dariocravero
Contributor

dariocravero commented Oct 16, 2014

Hi all,

tilt 2 has been out for a while now and sinatra already has support for it although it hasn't been unlocked because they didn't release 1.4.5's successor yet.

Overall the new version (apart from being maintained - notice there were no updates to v1 since 2013) includes code refactors and a new functionality for mappings. I've asked the author about the benefits here.

However, I think we should upgrade soon. Perhaps we should coordinate that with sinatra's release? Thoughts @padrino/core-members?

Thanks,
Darío

@dariocravero dariocravero changed the title from Tilt 2 support to tilt 2 support Oct 16, 2014

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 16, 2014

Member

I think we could adapt tilt 2 with 0.13 release. 0.12 branch should be as is.

Member

ujifgc commented Oct 16, 2014

I think we could adapt tilt 2 with 0.13 release. 0.12 branch should be as is.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Oct 16, 2014

Member

We must check our SafeBuffer support for Tilt 2. As far as I remember, Tilt 2 hasn't made a move in that respect.

Member

skade commented Oct 16, 2014

We must check our SafeBuffer support for Tilt 2. As far as I remember, Tilt 2 hasn't made a move in that respect.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 16, 2014

Member

It seems to work on my box if I use SINATRA_EDGE.

Member

ujifgc commented Oct 16, 2014

It seems to work on my box if I use SINATRA_EDGE.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 16, 2014

Member

👍 Seems like a good idea as we move onto 0.13

Member

nesquena commented Oct 16, 2014

👍 Seems like a good idea as we move onto 0.13

@ujifgc ujifgc added this to the 0.13.0 milestone Oct 16, 2014

@dg-ratiodata

This comment has been minimized.

Show comment
Hide comment
@dg-ratiodata

dg-ratiodata commented Dec 28, 2014

@ujifgc ujifgc modified the milestone: 0.13.0 Oct 12, 2015

@nesquena nesquena modified the milestone: 0.13.1 Oct 12, 2015

@ujifgc ujifgc modified the milestone: 0.13.1 Dec 12, 2015

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jan 15, 2016

Member

Seems like the last thing holding tilt1 is here:

s.add_dependency("tilt", "~> 1.4.1")

I will test it soon.

Member

ujifgc commented Jan 15, 2016

Seems like the last thing holding tilt1 is here:

s.add_dependency("tilt", "~> 1.4.1")

I will test it soon.

@ujifgc ujifgc added the enhancement label Jan 15, 2016

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Jan 26, 2016

I (and Middleman) would love this.

tdreyno commented Jan 26, 2016

I (and Middleman) would love this.

@ujifgc ujifgc closed this in e8c2f86 Jan 27, 2016

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno commented Jan 27, 2016

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment