New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button looks kinda strange #2008

Closed
blindpenguin opened this Issue Mar 3, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@blindpenguin

blindpenguin commented Mar 3, 2016

Hi there,

the logout button of the admin page looks a little bit strange. According to the source code, there is an additional "button" element, which is empty. I noticed it while restyling some of the CSS stuff. To make sure if it's my fail or not, i created another project without any changes, and there is the same problem. Looks like there's something wrong.

Screenshot

And here the automagically generated code:

li class='navbar-logout' = button_to(pat(:logout), url(:sessions, :destroy), :method => :delete, :class => 'navbar-nav-form') do = content_tag :button, tag_icon(:'power-off'), :type => :submit, :title => pat(:logout), :class => 'navbar-nav-form-link'

Oh, and btw.: I'm using Google Chrome 48.0.2564.116

@namusyaka namusyaka closed this in 9509963 Mar 6, 2016

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Mar 6, 2016

Member

@blindpenguin Thanks for the report! That is a bug, we didn't consider this change.
Now, the problem has been fixed. Please let us know if you still have a problem.

Member

namusyaka commented Mar 6, 2016

@blindpenguin Thanks for the report! That is a bug, we didn't consider this change.
Now, the problem has been fixed. Please let us know if you still have a problem.

@blindpenguin

This comment has been minimized.

Show comment
Hide comment
@blindpenguin

blindpenguin Mar 8, 2016

Thank you very much. I copied the change into my template. Works just nice. :)

blindpenguin commented Mar 8, 2016

Thank you very much. I copied the change into my template. Works just nice. :)

ujifgc added a commit that referenced this issue Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment