New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project generator silently ignores invalid -a option #2150

Closed
white-monkey opened this Issue Aug 10, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@white-monkey

white-monkey commented Aug 10, 2017

With current version 0.14.1.1:

$ padrino g project test -d sequel -a access97

successfully generates the project, even though the RDBMS value is obviously invalid, and uses sqlite as default. I would expect an error message instead.

@wikimatze

This comment has been minimized.

Member

wikimatze commented Aug 26, 2017

Hi @white-monkey thanks for the feedback. Do you mean a text-message like:

The provided database adapter 'access97' is not valid. Valid adapters are 'sqlite', 'mysql', 'mysql2', 'mysql-gem', 'postgres'.

What do other @padrino/core-members think about this change?

@ujifgc

This comment has been minimized.

Member

ujifgc commented Aug 27, 2017

Of course it's a bug.

@ujifgc ujifgc added the bug label Aug 27, 2017

@wikimatze

This comment has been minimized.

Member

wikimatze commented Aug 27, 2017

@ujifgc is the message I've provided okay? If yes, I would like to implement this change.

@ujifgc

This comment has been minimized.

Member

ujifgc commented Aug 27, 2017

Sure.

@ujifgc ujifgc closed this in 7fc1057 Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment