Skip to content
This repository

XSS on admin login page #639

Closed
eikes opened this Issue August 22, 2011 · 1 comment

2 participants

Eike Send Davide D'Agostino
Eike Send

The :email and :password variables are not escaped in the Admin controller. Also GET vars can be used where only POST should be used.

possibly adding

  params[:email] = escape_html(params[:email])
  params[:password] = escape_html(params[:password])

before

  flash[:warning] = "Login or password wrong."

might help, but I haven't tried it.

Example for this XSS (view in Firefox or Opera or IE, Webkit filters this kind of XSS):

http://www.padrinorb.com/admin/sessions/new?email=%22%3E%3Cscript%3Ealert%28%22XSS%22%29%3C/script%3E%3Cinput

Davide D'Agostino
Owner

Thanks man, will be applied soon!

Davide D'Agostino DAddYE closed this issue from a commit August 30, 2011
Davide D'Agostino Fix #639 9f4c315
Davide D'Agostino DAddYE closed this in 9f4c315 August 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.