New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create minitest generator component #667

Closed
nesquena opened this Issue Sep 12, 2011 · 12 comments

Comments

Projects
None yet
3 participants
@nesquena
Member

nesquena commented Sep 12, 2011

We should add a minitest test generator choice, i.e padrino g project demo -t minitest which requires the gem unless its 1.9. If you guys agree lets get this in for 0.10.3 or 0.10.4

@ghost ghost assigned achiu Sep 12, 2011

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Sep 14, 2011

Member

@achiu I suggest to target it to the 10.3, you agree? Sinatra 1.3 will be released soon, are u ready?

Member

DAddYE commented Sep 14, 2011

@achiu I suggest to target it to the 10.3, you agree? Sinatra 1.3 will be released soon, are u ready?

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Sep 14, 2011

Member

ready!

Member

achiu commented Sep 14, 2011

ready!

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 25, 2011

Member

@DAddYE @achiu Pushed a minitest component here: https://github.com/padrino/padrino-framework/tree/minitest_component. Can you guys review and test that branch so we can merge it back in?

Member

nesquena commented Sep 25, 2011

@DAddYE @achiu Pushed a minitest component here: https://github.com/padrino/padrino-framework/tree/minitest_component. Can you guys review and test that branch so we can merge it back in?

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Sep 26, 2011

Member

@nesquena thanks for the minitest component. I was wondering though about whether it should default use minitest spec or test/unit style. perhaps an option? what do you guys think?

Member

achiu commented Sep 26, 2011

@nesquena thanks for the minitest component. I was wondering though about whether it should default use minitest spec or test/unit style. perhaps an option? what do you guys think?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 26, 2011

Member

Yeah I mean there's no easy way to make it an option. It would have to be two separate component choices. Not sure if I want minitest_unit and minitest_spec components. I just went with autorun+spec which is what I think the common case is. Thoughts?

Member

nesquena commented Sep 26, 2011

Yeah I mean there's no easy way to make it an option. It would have to be two separate component choices. Not sure if I want minitest_unit and minitest_spec components. I just went with autorun+spec which is what I think the common case is. Thoughts?

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Sep 26, 2011

Member

I think we can make a default like this:

describe 'foo bar' do
  it 'should do some thing' do
    assert Foo.is_true?
  end
end

So DSL + Asseritions. Bad idea?

Member

DAddYE commented Sep 26, 2011

I think we can make a default like this:

describe 'foo bar' do
  it 'should do some thing' do
    assert Foo.is_true?
  end
end

So DSL + Asseritions. Bad idea?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 26, 2011

Member

Oh so keep describe/it but switch from .must_equal to assert_equal? I'm ok with that. Kind of a middle ground approach?

Member

nesquena commented Sep 26, 2011

Oh so keep describe/it but switch from .must_equal to assert_equal? I'm ok with that. Kind of a middle ground approach?

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Sep 26, 2011

Member

I think describe / it can be great for 99% of us, but I also think that now assert is much common than must or should. Btw switch from them is quite simple but assert in my mind is more standard.

Im right with both, sometimes I use assert sometimes must I don't really have a preference.

Member

DAddYE commented Sep 26, 2011

I think describe / it can be great for 99% of us, but I also think that now assert is much common than must or should. Btw switch from them is quite simple but assert in my mind is more standard.

Im right with both, sometimes I use assert sometimes must I don't really have a preference.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 26, 2011

Member

OK, I agree that describe/it is better in almost all cases. I also don't have a strong preference for assert over must, with a slight edge to assert just because as you said it is more common. @achiu Right now I used must assertion types, can you review the branch and tweak it to use assert instead in the model and controller minitest generators? Or alternatively curious to hear what you think the right "default" is here.

Member

nesquena commented Sep 26, 2011

OK, I agree that describe/it is better in almost all cases. I also don't have a strong preference for assert over must, with a slight edge to assert just because as you said it is more common. @achiu Right now I used must assertion types, can you review the branch and tweak it to use assert instead in the model and controller minitest generators? Or alternatively curious to hear what you think the right "default" is here.

achiu added a commit that referenced this issue Sep 27, 2011

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Sep 27, 2011

Member

switch to use assert/refute assertions instead and merged back to master. closing ticket.

Member

achiu commented Sep 27, 2011

switch to use assert/refute assertions instead and merged back to master. closing ticket.

@achiu achiu closed this Sep 27, 2011

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 27, 2011

Member

Awesome, glad to have this closed. Thanks @achiu.

Member

nesquena commented Sep 27, 2011

Awesome, glad to have this closed. Thanks @achiu.

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Sep 27, 2011

Member

Thanks @achiu

Member

DAddYE commented Sep 27, 2011

Thanks @achiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment