New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinatra 1.3 :static_cache_control non functional? #692

Closed
veesahni opened this Issue Oct 5, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@veesahni

veesahni commented Oct 5, 2011

I upgraded to padrino 10.3 (and sinatra 1.3.1) and added the following in app.rb:

set :static_cache_control => [:public, :max_age => 86400]

I don't see any cache control header being tagged onto static files being served out of public/ .. am I missing something or is this sinatra feature not supported by padrino?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 5, 2011

Member

This feature should be supported by padrino and is not supported only because of a bug. Thanks for bringing this up, somehow this behavior fell through the cracks in Padrino based on our handling of static assets.

@DAddYE @joshbuddy (look at our static! method vs latest sinatra). Can you recommend this guy a workaround?

Member

nesquena commented Oct 5, 2011

This feature should be supported by padrino and is not supported only because of a bug. Thanks for bringing this up, somehow this behavior fell through the cracks in Padrino based on our handling of static assets.

@DAddYE @joshbuddy (look at our static! method vs latest sinatra). Can you recommend this guy a workaround?

@nesquena nesquena closed this in da0201a Oct 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment