#822 describes a case for relaxing Padrinos dependency on ActiveSupport. To realize this, the active_support dependency must move out of the gemspec into the (generated) Gemfile.
The bigger thing is that it means that we have to decide on a way to test multiple dependency sets.
state_machine uses appraisal (see https://github.com/pluginaweek/state_machine for a huge example) for this, is this an option?
For discussion purposes, I did a quick and dirty code spike:
bundle exec rake appraisal:install
bundle exec rake appraisal
This will run all tests with activesupport 3.0,3.1 and 3.2.
gem "foobar", :platform => :jruby
gem "barfoo", :group => :cache
All tests pass as before.
Any opinions on this? @DAddYE
As this seems to be scheduled for 0.10.8, whats the opinion on the actual proposed solution? /cc @DAddYE
Ok, let's go, we can try it
We should be testing against the AS edge too ?
Padrino-helpers requires this file:
require 'active_support/core_ext/float/rounding' # round
This file no longer exists in edge active_support. This is making it hard to include edge dependencies in Padrino apps.
@lancecarlson Thanks for the report, hopefully we can investigate and fix this soon. Do you happen to know how to include the 'round' functionality in edge now?
I was looking for it and couldn't find it anywhere. Is this a built in feature of 1.9 or something?
Good call, in that case just need to rescue if that require fails.
Added into head: https://github.com/padrino/padrino-framework/blob/master/padrino-helpers/lib/padrino-helpers.rb#L10
Awesome!! Anyway you can relax the activesupport requirements for padrino-core too?
Going to provide a commit for this.
Couldn't figure out how to reference the commit. Here it is:
Closing this since @skade's patch on #1003 was already merged.