New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expire helper does not delete key in Redis #873

Closed
gugat opened this Issue Jul 2, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@gugat
Contributor

gugat commented Jul 2, 2012

I am trying the cache store with redis in padrino 0.10.3, ruby 1.9.2p320 on Ubuntu 10.04.

I can save a new key-value pair using the cache helper, then when using the expire helper it does not delete it.

For example, if "mykeytest" is cached

cache( "mykeytest", :expires_in => 30 ) do
    Time.now.to_s
 end     

and then I try

expire("mykeytest")

redis-cli monitor shows

"del" "[\"mykeytest\"]"

The key was passed as a string to expire, but it seems like Padrino adds it to an Array and then that array is converted to String and finally passed to Redis.

The command in redis-cli monitor should look like:

"del" "mykeytest"

to work properly.

@DAddYE DAddYE closed this in b31967c Jul 4, 2012

ujifgc pushed a commit to ujifgc/padrino-framework that referenced this issue Jul 5, 2012

Merge pull request #874 from gugat/expire_helper
Get the first key passed to expire helper. Fixes #873
@Rylon

This comment has been minimized.

Show comment
Hide comment
@Rylon

Rylon Aug 15, 2012

Thanks for this patch, just wondering if there was an ATA for when this might make it into a release? I'm currently monkey patching the fix you see.

Thanks!

Rylon commented Aug 15, 2012

Thanks for this patch, just wondering if there was an ATA for when this might make it into a release? I'm currently monkey patching the fix you see.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment