New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced Generators #1011

Merged
merged 5 commits into from Jan 29, 2013

Conversation

Projects
None yet
3 participants
@achiu
Member

achiu commented Jan 14, 2013

As per #741

  • namespaced projects
  • namespaced (sub) apps
  • namespaced controllers
  • namespaced helpers
  • namespaced models
  • namespaced admin

This is pretty much working and only missing these last few pieces.

  • How do we handle namespaced models when it comes to migrations? Does this affect some ORM migrations
    when its namespaced?(activerecord)
  • How do we handle the models associated tables? Do they include the namespace as well?

Once you guys take a look at this and tell me what you think, I'll go ahead and update padrino-admin
to leverage this or have @DAddYE do it 馃榿. It still works regardless of namespaced feature.

achiu added a commit that referenced this pull request Jan 29, 2013

@achiu achiu merged commit 28b1755 into master Jan 29, 2013

1 check passed

default The Travis build passed
Details

@achiu achiu deleted the feature/namespaced_generator branch Jan 29, 2013

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 29, 2013

Member

Have we finally decided on that, see the discussion in #741 ?

Member

skade commented Jan 29, 2013

Have we finally decided on that, see the discussion in #741 ?

tyabe added a commit to tyabe/padrino-framework that referenced this pull request Feb 19, 2013

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Mar 13, 2013

Contributor

@achiu we're now namespacing admin apps too! It will hit master in a bit... See this :)

Contributor

dariocravero commented Mar 13, 2013

@achiu we're now namespacing admin apps too! It will hit master in a bit... See this :)

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Mar 13, 2013

Member

@dariocravero great job! 馃憤馃憤馃憤

Member

achiu commented Mar 13, 2013

@dariocravero great job! 馃憤馃憤馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment