New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ree and 1.9.2 from testing, add rbx instead #1022

Merged
merged 2 commits into from Jan 26, 2013

Conversation

Projects
None yet
4 participants
@skade
Member

skade commented Jan 25, 2013

Given that most providers have switched for Ruby 1.9.3 and 1.9.2 is really out of style, I switched off the build for it. Same goes for ree - I think testing 1.8.7 is currently enough to keep compatibility.

I took the liberty of activating optional testing on rbx.

This helps save resources on travis.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jan 25, 2013

Member

Thanks, I agree. Not too overly worried about 1.8.7 compatibility anymore. This makes sense to me @achiu @DAddYE ?

Member

nesquena commented Jan 25, 2013

Thanks, I agree. Not too overly worried about 1.8.7 compatibility anymore. This makes sense to me @achiu @DAddYE ?

@WaYdotNET

This comment has been minimized.

Show comment
Hide comment
@WaYdotNET

WaYdotNET Jan 25, 2013

Contributor

+1

Contributor

WaYdotNET commented Jan 25, 2013

+1

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jan 26, 2013

Member

Good change, but we should state rbx mode explicitly. It now defaults to 1.8 mode http://about.travis-ci.org/blog/vm_upgrade_oct_31_2011/

Member

ujifgc commented Jan 26, 2013

Good change, but we should state rbx mode explicitly. It now defaults to 1.8 mode http://about.travis-ci.org/blog/vm_upgrade_oct_31_2011/

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 26, 2013

Member

@ujifgc The problem being? At the moment, I wouldn't touch rbx 19mode with a stick, as its not finished yet. Any failures there are basically to be expected. So defaulting to whatever the current hotness is for travis for an optional test is completely fine.

Member

skade commented Jan 26, 2013

@ujifgc The problem being? At the moment, I wouldn't touch rbx 19mode with a stick, as its not finished yet. Any failures there are basically to be expected. So defaulting to whatever the current hotness is for travis for an optional test is completely fine.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jan 26, 2013

Member

For me it's not obvious that rbx means rbx-18mode. If I'm the only one confused, then okay, but I still think we should not lean on travis not to break this when they decide 1.9 mode is ready.

Member

ujifgc commented Jan 26, 2013

For me it's not obvious that rbx means rbx-18mode. If I'm the only one confused, then okay, but I still think we should not lean on travis not to break this when they decide 1.9 mode is ready.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 26, 2013

Member

I don't want to argue it too much, as the test is allowed to fail anyways: heres your patch :).

Member

skade commented Jan 26, 2013

I don't want to argue it too much, as the test is allowed to fail anyways: heres your patch :).

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 26, 2013

Member

Merging this, as there was no opposition.

Member

skade commented Jan 26, 2013

Merging this, as there was no opposition.

skade added a commit that referenced this pull request Jan 26, 2013

Merge pull request #1022 from padrino/be-nicer-to-travis
Remove ree and 1.9.2 from testing, add rbx instead

@skade skade merged commit f69db98 into master Jan 26, 2013

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jan 26, 2013

Member

Thanks

Member

nesquena commented Jan 26, 2013

Thanks

@nesquena nesquena deleted the be-nicer-to-travis branch Jan 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment