New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveSupport::JSON for dumping json in render #1025

Merged
merged 1 commit into from Jan 26, 2013

Conversation

Projects
None yet
1 participant
@skade
Member

skade commented Jan 26, 2013

This relieves us of any extra work that comes with handling JSON engines, etc. and ensures that rendering of json works without extra requires.

Closed #1023 and #1024,

Use ActiveSupport::JSON for dumping json in render
This relieves us of any extra work that comes with handling JSON engines, etc.
@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 26, 2013

Member

I don't feel this merits a lot of discussion. As we do already depend on library abstracting away from handling/loading multiple JSON libraries, there is no point in not using it.

Revert if necessary.

Member

skade commented Jan 26, 2013

I don't feel this merits a lot of discussion. As we do already depend on library abstracting away from handling/loading multiple JSON libraries, there is no point in not using it.

Revert if necessary.

@skade skade closed this Jan 26, 2013

@skade skade reopened this Jan 26, 2013

skade added a commit that referenced this pull request Jan 26, 2013

Merge pull request #1025 from padrino/active-support-json
Use ActiveSupport::JSON for dumping json in render

@skade skade merged commit e8d7d3c into master Jan 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment