New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reloader #1086

Merged
merged 5 commits into from Mar 24, 2013

Conversation

Projects
None yet
3 participants
@Ortuna
Member

Ortuna commented Feb 28, 2013

This is a bolder refactoring, so please let me know if it's not up to par. I wanted to make the reloader more readable and in doing such easier to build on. While it still could use some more TLC with more complex portions, I think this is a good starting point.

Thanks!

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Mar 10, 2013

Member

@DAddYE can you take a look at this? Would you want to include this in 0.11.0?

Member

nesquena commented Mar 10, 2013

@DAddYE can you take a look at this? Would you want to include this in 0.11.0?

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Mar 18, 2013

Member

@Ortuna I like that! Can you move silence_thing and everything not strict with reloader on support_lite.rb?

Member

DAddYE commented Mar 18, 2013

@Ortuna I like that! Can you move silence_thing and everything not strict with reloader on support_lite.rb?

@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Mar 22, 2013

Member

@DAddYE I couldn't think of a logical place to put the silence/unsilence methods so I created a Padrino::Utils class(in support_lite.rb). Since those are very generic methods. Unfortunately all the other refactored methods are tied to the reloader, but the refactoring should help with the reading of the code(Reloader is complex).

Member

Ortuna commented Mar 22, 2013

@DAddYE I couldn't think of a logical place to put the silence/unsilence methods so I created a Padrino::Utils class(in support_lite.rb). Since those are very generic methods. Unfortunately all the other refactored methods are tied to the reloader, but the refactoring should help with the reading of the code(Reloader is complex).

DAddYE added a commit that referenced this pull request Mar 24, 2013

@DAddYE DAddYE merged commit a3068e3 into padrino:master Mar 24, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment