Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix invalid markup in mail_to (ampersand not escaped) #1139
Escape ampersands for validation.
It looks like this should probably be handled in the link_to helper, but I am not familiar enough with standards to know if
Less hacky/more general solutions welcome to whoever knows more about the standards specs!
added a commit
this pull request
Mar 18, 2013
No prob. Pulled the latest changes locally and now mail to validates properly. However, I put together a case with a simple anchor tag with an href that had an ampersand, and it complains about that too (both validator.nu and W3C) so it looks like this is a more general issue with the Rack::Utils function that builds the query string.
At this point I'm not sure what I should change and where; there are a few cases:
Should I open another issue for further review?
~ Jonathan Martin