New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for Test::Unit/Shoulda/RR test cases #1212

Merged
merged 2 commits into from Apr 1, 2013

Conversation

Projects
None yet
2 participants
@sshaw
Contributor

sshaw commented Apr 1, 2013

These problems have been around for sometime:

i. Include RR::Adapters::TestUnit instead of RR::Adapters::RRMethods in test_config.rb

RR::Adapters::TestUnit verifies and resets expectations (it includes RR::Adapters::RRMethods) and defines assert_received.

ii. Don't require shoulda/active_record in test_config.rb

I don't think this has been necessary since shoulda was separated into context and matchers

iii. require test/unit in test_config.rb

I looked into this a while ago and, if I recall, this is necessary now that MiniTest is part of ruby (as it now provides Test::Unit -this could have implications with the test unit generator, but I'm not sure). Without it, no tests will be run.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Apr 1, 2013

Member

Thanks!

Member

nesquena commented Apr 1, 2013

Thanks!

nesquena added a commit that referenced this pull request Apr 1, 2013

Merge pull request #1212 from sshaw/master
Some fixes for Test::Unit/Shoulda/RR test cases

@nesquena nesquena merged commit 3c4f995 into padrino:master Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment