New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for block arg to StandardFormBuilder.label #1228

Merged
merged 2 commits into from Apr 8, 2013

Conversation

Projects
None yet
2 participants
@sshaw
Contributor

sshaw commented Apr 6, 2013

The labe_tag helper allows for a block but @form_builder.label does not.

@sshaw

This comment has been minimized.

Show comment
Hide comment
@sshaw

sshaw Apr 6, 2013

Contributor

Oops... I see I inadvertently duplicated a test. The 2nd commit removed it.

Contributor

sshaw commented Apr 6, 2013

Oops... I see I inadvertently duplicated a test. The 2nd commit removed it.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Apr 8, 2013

Member

Good catch @sshaw, thanks for adding proper testing too!

Member

nesquena commented Apr 8, 2013

Good catch @sshaw, thanks for adding proper testing too!

nesquena added a commit that referenced this pull request Apr 8, 2013

Merge pull request #1228 from sshaw/form_builder_label
Allow for block arg to StandardFormBuilder.label

@nesquena nesquena merged commit 6b00a0a into padrino:master Apr 8, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment