New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padrino::Server - call expand_path on PID file option #1232

Merged
merged 1 commit into from Apr 8, 2013

Conversation

Projects
None yet
2 participants
@sshaw
Contributor

sshaw commented Apr 8, 2013

Normally Rack::Server would expand the PID (-P) argument. But with Padrino::Server, there is no ARGV for Rack::Server to parse, so a PID option that's not absolute will cause Padrino::Server to silently fail when it daemonizes as it will be attempting to open the file from the root directory ("/") not the directory from which it was invoked.

On a related note, why not just mimic the Rack::Server/rackup options? While it's is a minor issue, standardization is good. For example, this is somewhat confusing:

> padrino start -di some/pid/file.pid
> padrino stop -i some/pid/file.pid
padrino stop requires at least 0 argument: "padrino stop".
> padrino stop -p some/pid/file.pid
=> Sending INT to process with pid 57493 wait

nesquena added a commit that referenced this pull request Apr 8, 2013

Merge pull request #1232 from sshaw/server_pid_path
Padrino::Server - call expand_path on PID file option

@nesquena nesquena merged commit ef453cc into padrino:master Apr 8, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment