New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent logging of health-check requests at log level over :debug #1250

Merged
merged 1 commit into from Jul 1, 2013

Conversation

Projects
None yet
4 participants
@tyabe
Contributor

tyabe commented Apr 20, 2013

because, even if specify log level anything, It is always output.
Is this the intended behavior?

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Apr 22, 2013

Contributor

Mmm I'd leave it on dev too... @padrino/core-members ?

Contributor

dariocravero commented Apr 22, 2013

Mmm I'd leave it on dev too... @padrino/core-members ?

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Apr 22, 2013

Member

Keeping it off in dev just moves the time of the bang.

Am 22.04.2013 um 05:36 schrieb Darío Javier Cravero notifications@github.com:

Mmm I'd leave it on dev too... @padrino/core-members ?


Reply to this email directly or view it on GitHub.

Member

skade commented Apr 22, 2013

Keeping it off in dev just moves the time of the bang.

Am 22.04.2013 um 05:36 schrieb Darío Javier Cravero notifications@github.com:

Mmm I'd leave it on dev too... @padrino/core-members ?


Reply to this email directly or view it on GitHub.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Apr 22, 2013

Member

Sorry, wrong issue, this was about #1251

On Apr 22, 2013, at 7:11 AM, Florian Gilcher florian.gilcher@asquera.de wrote:

Keeping it off in dev just moves the time of the bang.

Am 22.04.2013 um 05:36 schrieb Darío Javier Cravero notifications@github.com:

Mmm I'd leave it on dev too... @padrino/core-members ?


Reply to this email directly or view it on GitHub.

Member

skade commented Apr 22, 2013

Sorry, wrong issue, this was about #1251

On Apr 22, 2013, at 7:11 AM, Florian Gilcher florian.gilcher@asquera.de wrote:

Keeping it off in dev just moves the time of the bang.

Am 22.04.2013 um 05:36 schrieb Darío Javier Cravero notifications@github.com:

Mmm I'd leave it on dev too... @padrino/core-members ?


Reply to this email directly or view it on GitHub.

DAddYE added a commit that referenced this pull request Jul 1, 2013

Merge pull request #1250 from tyabe/fix_health-check_logging
Prevent logging of health-check requests at log level over :debug

@DAddYE DAddYE merged commit f72fed2 into padrino:master Jul 1, 2013

1 check failed

default The Travis build failed
Details
@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jul 1, 2013

Member

Makes sense, If I'm not drunk 👯 I debug is an higher level than devel so devel profile should catch it

Member

DAddYE commented Jul 1, 2013

Makes sense, If I'm not drunk 👯 I debug is an higher level than devel so devel profile should catch it

@tyabe tyabe deleted the tyabe:fix_health-check_logging branch Jul 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment