New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to show use case for routing priority #1257

Merged
merged 1 commit into from Jul 28, 2013

Conversation

Projects
None yet
4 participants
@jeffutter

jeffutter commented Apr 24, 2013

This test shows a (currently failing) use case for routing priority as it worked in 0.10 but seems to be broken in 0.11.

In my app I have a bunch of urls that related to 'pages' the content of which is stored in a DB. These need to be accessed at /:page_name . I also have some controllers with more 'hard coded' pages (shopping cart/contact form, etc.) The problem is the index route in the app.rb should be the last possible route after all the controllers. As it stands it is about the 3rd route... before all of the controllers and thus catches everything resembling a controller.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 15, 2013

Contributor

Thanks @jeffutter we'll try to fix this as soon as possible!..

Contributor

dariocravero commented May 15, 2013

Thanks @jeffutter we'll try to fix this as soon as possible!..

@ghost ghost assigned DAddYE Jul 1, 2013

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jul 1, 2013

Member

I'll add it back but for 1.0 I think will gone ... forever

Member

DAddYE commented Jul 1, 2013

I'll add it back but for 1.0 I think will gone ... forever

@jeffutter

This comment has been minimized.

Show comment
Hide comment
@jeffutter

jeffutter Jul 11, 2013

Great, thanks for this. Will there be another solution for something like this in 1.0? It seems like a fairly common need in routing - some way to set order of routes. With routes in Padrino occurring in multiple files it seems difficult to control the order as it is now.

jeffutter commented Jul 11, 2013

Great, thanks for this. Will there be another solution for something like this in 1.0? It seems like a fairly common need in routing - some way to set order of routes. With routes in Padrino occurring in multiple files it seems difficult to control the order as it is now.

ujifgc added a commit that referenced this pull request Jul 28, 2013

Merge pull request #1257 from jeffutter/catch-all-after-controllers
Add a test to show use case for routing priority

@ujifgc ujifgc merged commit ea601ba into padrino:master Jul 28, 2013

1 check failed

default The Travis build failed
Details
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 28, 2013

Member

This works now after @namusyaka 's fix #1361

Member

ujifgc commented Jul 28, 2013

This works now after @namusyaka 's fix #1361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment