New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :file option as a new delivery_method for mails #1285

Merged
merged 3 commits into from May 15, 2013

Conversation

Projects
None yet
2 participants
@wikimatze
Member

wikimatze commented May 13, 2013

I was searching for all possible options for sending mails and stumbled upon the edgerails guide which mentioned methods which aren't still part of the documentation.

I updated the mailer.rb.tt template with an example.

Matthias

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 15, 2013

Contributor

It's brilliant @matthias-guenther!! Thanks! :)

What I'd change on it so that it's not that confusing is the path. See the comment on the code. Could you rephrase that? Thanks!

Contributor

dariocravero commented May 15, 2013

It's brilliant @matthias-guenther!! Thanks! :)

What I'd change on it so that it's not that confusing is the path. See the comment on the code. Could you rephrase that? Thanks!

@dariocravero

View changes

Show outdated Hide outdated padrino-gen/lib/padrino-gen/generators/templates/mailer.rb.tt

@ghost ghost assigned dariocravero May 15, 2013

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 15, 2013

Contributor

Amazing stuff! Thanks! :)

Contributor

dariocravero commented May 15, 2013

Amazing stuff! Thanks! :)

dariocravero added a commit that referenced this pull request May 15, 2013

Merge pull request #1285 from matthias-guenther/master
Add :file option as a new delivery_method for mails

@dariocravero dariocravero merged commit 4c4ac54 into padrino:master May 15, 2013

1 check passed

default The Travis CI build passed
Details
@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze May 16, 2013

Member

I'm glad to help!

Member

wikimatze commented May 16, 2013

I'm glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment