New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing comma to spec_helper.rb when generated using the -t command #1297

Merged
merged 1 commit into from May 24, 2013

Conversation

Projects
None yet
2 participants
@lmorduch
Contributor

lmorduch commented May 24, 2013

This fixes the first issue described here:
#1296

where the spec_helper.rb generated by the command:

padrino generate project test -b true -t rspec -e erb

creates a spec_helper.rb that is missing a comma at this line:

def app(app = nil &blk)

The only change made is making the above line this:

def app(app = nil, &blk)

in the files located at padrino-gen/lib/padrino-gen/generators/components/tests/

achiu added a commit that referenced this pull request May 24, 2013

Merge pull request #1297 from lmorduch/master
Added missing comma to spec_helper.rb when generated using the -t command

@achiu achiu merged commit b34c117 into padrino:master May 24, 2013

1 check was pending

default The Travis CI build is in progress
Details
@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu May 24, 2013

Member

@lmorduch thanks for the fix!

Member

achiu commented May 24, 2013

@lmorduch thanks for the fix!

@lmorduch

This comment has been minimized.

Show comment
Hide comment
@lmorduch

lmorduch May 24, 2013

Contributor

Np! Glad to contribute :)

Contributor

lmorduch commented May 24, 2013

Np! Glad to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment