New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make caption arg in submit-tag helper optional even when options args are supplied #1318

Merged
merged 2 commits into from Jul 1, 2013

Conversation

Projects
None yet
2 participants
@dayflower
Contributor

dayflower commented Jun 24, 2013

When I use FormHelpers#submit_tag without caption arg,

submit_tag :class => "btn"

I expect

<input type="submit" class="btn" value="Submit" />

But I get

<input type="submit" value-class="btn" />

I know that a caption arg is mandatory when options args are specified, but I think it's useful if we can omit a caption arg.

(Furthermore, IMHO, on above example condition, outputting as follows would be reasonable (value attr is omitted). In this pull-req I did'nt touch so, but how do you think about this idea?)

<input type="submit" class="btn" />

DAddYE added a commit that referenced this pull request Jul 1, 2013

Merge pull request #1318 from dayflower/optional-submit-caption
Make caption arg in submit-tag helper optional even when options args are supplied

@DAddYE DAddYE merged commit 97294d1 into padrino:master Jul 1, 2013

1 check passed

default The Travis CI build passed
Details
@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jul 1, 2013

Member

Nice! Thank you!

Member

DAddYE commented Jul 1, 2013

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment