New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some auto-detection for authenticity_token & form_tag #1320

Merged
merged 1 commit into from Jun 24, 2013

Conversation

Projects
None yet
5 participants
@Ortuna
Member

Ortuna commented Jun 24, 2013

  • if the application has protect_from_csrf set to false, do not include authenticity_token
  • if :protect_from_csrf => false option is passed to #form_tag, do not include authenticity_token
  • defaults to stricter :protect_from_csrf if protection is unknown for safety

Closes #1266

Some auto-detection for authenticity_token & form_tag
- if the application has protect_from_csrf set to false, do not include authenticity_token
- if :protect_from_csrf => false option is passed to #form_tag, do not include authenticity_token
- defaults to stricter :protect_from_csrf if protection is unknown for safety

Closes #1266
@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern Jun 24, 2013

Contributor

Nice, looks good.

Contributor

postmodern commented Jun 24, 2013

Nice, looks good.

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jun 24, 2013

Member

To me too! Feel free to merge

Member

DAddYE commented Jun 24, 2013

To me too! Feel free to merge

@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Jun 24, 2013

Member

Was gonna wait on tests Travis is having troubles today.

Member

Ortuna commented Jun 24, 2013

Was gonna wait on tests Travis is having troubles today.

Ortuna added a commit that referenced this pull request Jun 24, 2013

Merge pull request #1320 from Ortuna/csrf_form_tag
Some auto-detection for authenticity_token & form_tag

@Ortuna Ortuna merged commit ba71c47 into padrino:master Jun 24, 2013

1 check passed

default The Travis CI build passed
Details
@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jun 24, 2013

Member

Nice work @Ortuna

Member

nesquena commented Jun 24, 2013

Nice work @Ortuna

@Ortuna Ortuna deleted the Ortuna:csrf_form_tag branch Jun 25, 2013

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Jun 25, 2013

Contributor

Thanks for putting this up together :) 👏

Contributor

dariocravero commented Jun 25, 2013

Thanks for putting this up together :) 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment