New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed :grouped_options of select_tag. #1337

Merged
merged 1 commit into from Jul 7, 2013

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Jul 7, 2013

Reference to issue #1294.
When using content_tag and other tag helpers in template of erb or slim, __erb_in_template is always defined.
So, I thought that concat_content(output) is executed in #content_tag, against my own will.
This pull request is way of solving without using block in #grouped_options_for_select.

ujifgc added a commit that referenced this pull request Jul 7, 2013

Merge pull request #1337 from namusyaka/fix_grouped_options_of_select
don't use block for content_tag in #select_tag

@ujifgc ujifgc merged commit 5976923 into padrino:master Jul 7, 2013

1 check passed

default The Travis CI build passed
Details
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 7, 2013

Member

Thanks!

Member

ujifgc commented Jul 7, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment