New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache tests #1349

Merged
merged 3 commits into from Jul 14, 2013

Conversation

Projects
None yet
2 participants
@Ortuna
Member

Ortuna commented Jul 13, 2013

(WIP will squash to one commit) Done Please review
Redid tests for cache …

  • Each test is explicitly skipped rather than "warn" and not being eval'd.
  • Stub Time.now and use for expire base tests
    • Changed Redis to use #set and #expireat for timestamp based cache expire.
      "expires in" vs "expires at"
  • Use shared examples rather than read file and eval(slightly better failures)
  • Split tests into their each file

Ortuna added some commits Jul 13, 2013

Redid tests for cache
- Each test is explicitly skipped rather than "warn" and not being eval'd.
- Stub Time.now and use for expire base tests
   - Changed Redis to use #set and #expireat for timestamp based cache expire.
     "expires in" vs "expires at"
- Use shared examples rather than read file and eval(slightly better failures)
- Split tests into their each file
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 14, 2013

Member

Looks great!

Member

ujifgc commented Jul 14, 2013

Looks great!

ujifgc added a commit that referenced this pull request Jul 14, 2013

@ujifgc ujifgc merged commit 4a14eee into padrino:master Jul 14, 2013

1 check passed

default The Travis CI build passed
Details

@ujifgc ujifgc referenced this pull request Jul 14, 2013

Closed

Fix expiring test #1343

@Ortuna Ortuna deleted the Ortuna:cache-fix branch Jul 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment