New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add multipart option to form_for if include file_field #1355

Merged
merged 2 commits into from Jul 20, 2013

Conversation

Projects
None yet
2 participants
@tyabe
Contributor

tyabe commented Jul 20, 2013

No description provided.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 20, 2013

Member

As far as I can see from https://github.com/padrino/padrino-framework/pull/1355/files#L1R37, it makes form multipart even if :multipart => false? settings[:multipart] ||= instance.multipart makes false true.

And test assert_has_tag('form', :"accept-charset" => "UTF-8", :action => '/register') { actual_html } asserts a tag with multipart attribute as acceptable.

Member

ujifgc commented Jul 20, 2013

As far as I can see from https://github.com/padrino/padrino-framework/pull/1355/files#L1R37, it makes form multipart even if :multipart => false? settings[:multipart] ||= instance.multipart makes false true.

And test assert_has_tag('form', :"accept-charset" => "UTF-8", :action => '/register') { actual_html } asserts a tag with multipart attribute as acceptable.

@tyabe

This comment has been minimized.

Show comment
Hide comment
@tyabe

tyabe Jul 20, 2013

Contributor

Oops..
How's that sound?

Contributor

tyabe commented Jul 20, 2013

Oops..
How's that sound?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 20, 2013

Member

Seems okay. Waiting for Travis.

Member

ujifgc commented Jul 20, 2013

Seems okay. Waiting for Travis.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 20, 2013

Member

Thanks!

Member

ujifgc commented Jul 20, 2013

Thanks!

ujifgc added a commit that referenced this pull request Jul 20, 2013

Merge pull request #1355 from tyabe/multipart_form
Automatically add multipart option to form_for if include file_field

@ujifgc ujifgc merged commit 245be85 into padrino:master Jul 20, 2013

1 check passed

default The Travis CI build passed
Details

@ujifgc ujifgc referenced this pull request Jul 20, 2013

Closed

File upload #126

@tyabe tyabe deleted the tyabe:multipart_form branch Jul 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment