New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change content_type's default value for compatibility with Sinatra. #1395

Merged
merged 2 commits into from Sep 5, 2013

Conversation

Projects
None yet
3 participants
@namusyaka
Member

namusyaka commented Sep 5, 2013

ref #1350

I removed assignment expression which set a default value to @_content_type.
Accordingly, I changed some tests, and added _content_type variable to #resolve_template for integrity.

Please review this PR.
Thanks.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Sep 5, 2013

Contributor

Thanks @namusyaka! It makes sense to me, @padrino/core-members?

Contributor

dariocravero commented Sep 5, 2013

Thanks @namusyaka! It makes sense to me, @padrino/core-members?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 5, 2013

Member

Awesome!

Member

ujifgc commented Sep 5, 2013

Awesome!

ujifgc added a commit that referenced this pull request Sep 5, 2013

Merge pull request #1395 from namusyaka/change-content_type-value
Change content_type's default value for compatibility with Sinatra. Fixes #1350

@ujifgc ujifgc merged commit 8397964 into padrino:master Sep 5, 2013

1 check passed

default The Travis CI build passed
Details

@namusyaka namusyaka deleted the namusyaka:change-content_type-value branch Sep 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment