New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to pass options to submit_tag when using button_to #1404

Merged
merged 1 commit into from Sep 10, 2013

Conversation

Projects
None yet
2 participants
@graudeejs
Contributor

graudeejs commented Sep 9, 2013

Use case:
I wanted to add simple button with specific class. Turns out I had to pass a block. For such a simple scenario I think it's too much of work. So I propose this change (test included).

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 10, 2013

Member

Thank you for PR.
Looks good to me.
BTW, I think that :submit_options is not [Symbol] but [Hash].

Member

namusyaka commented Sep 10, 2013

Thank you for PR.
Looks good to me.
BTW, I think that :submit_options is not [Symbol] but [Hash].

@graudeejs

This comment has been minimized.

Show comment
Hide comment
@graudeejs

graudeejs Sep 10, 2013

Contributor

True, I'll fix that when I get home

Contributor

graudeejs commented Sep 10, 2013

True, I'll fix that when I get home

@graudeejs

This comment has been minimized.

Show comment
Hide comment
@graudeejs

graudeejs Sep 10, 2013

Contributor

Fixed (& force committed)

Contributor

graudeejs commented Sep 10, 2013

Fixed (& force committed)

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 10, 2013

Member

OK.
Thank you, @graudeejs!

Member

namusyaka commented Sep 10, 2013

OK.
Thank you, @graudeejs!

namusyaka added a commit that referenced this pull request Sep 10, 2013

Merge pull request #1404 from graudeejs/impoved_button_to
Make it possible to pass options to submit_tag when using button_to

@namusyaka namusyaka merged commit fcbe323 into padrino:master Sep 10, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment