New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core documentation cleanup #1407

Merged
merged 23 commits into from Sep 12, 2013

Conversation

Projects
None yet
3 participants
@wikimatze
Member

wikimatze commented Sep 12, 2013

After two tries this is the final one - it just cleaned up the documentation.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 12, 2013

Member

Looks fine to me.

Member

ujifgc commented Sep 12, 2013

Looks fine to me.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 12, 2013

Member

Great 👍
By the way, are module and class name comment not needed?
like this end # Padrino

Member

namusyaka commented Sep 12, 2013

Great 👍
By the way, are module and class name comment not needed?
like this end # Padrino

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 12, 2013

Member

Ideally, end # Padrino spews are not needed because the code is well structured and methods are short.

Member

ujifgc commented Sep 12, 2013

Ideally, end # Padrino spews are not needed because the code is well structured and methods are short.

ujifgc added a commit that referenced this pull request Sep 12, 2013

@ujifgc ujifgc merged commit 017e96a into padrino:master Sep 12, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment