New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache documentation cleanup #1410

Merged
merged 14 commits into from Sep 13, 2013

Conversation

Projects
None yet
3 participants
@wikimatze
Member

wikimatze commented Sep 13, 2013

No description provided.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 13, 2013

Member

Good work!
However, I think that we shouldn't indent private and protected methods.
(see: 8790a99)

Member

namusyaka commented Sep 13, 2013

Good work!
However, I think that we shouldn't indent private and protected methods.
(see: 8790a99)

@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze Sep 13, 2013

Member

Thanks, yeah I'm used to indent them to make them more readable, I'll fix it!

Member

wikimatze commented Sep 13, 2013

Thanks, yeah I'm used to indent them to make them more readable, I'll fix it!

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 13, 2013

Member

@matthias-guenther excess indenting of methods leads to this problem:

      end
    end
end
Member

ujifgc commented Sep 13, 2013

@matthias-guenther excess indenting of methods leads to this problem:

      end
    end
end
@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze Sep 13, 2013

Member

@ujifgc this make sense, I understand your point now. It is fixed now in 162e0

Member

wikimatze commented Sep 13, 2013

@ujifgc this make sense, I understand your point now. It is fixed now in 162e0

ujifgc added a commit that referenced this pull request Sep 13, 2013

Merge pull request #1410 from matthias-guenther/padrino-cache-documen…
…tation-cleanup

Cache documentation cleanup

@ujifgc ujifgc merged commit f4be73b into padrino:master Sep 13, 2013

1 check was pending

default The Travis CI build is in progress
Details
@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 13, 2013

Member

Thank you, @matthias-guenther!

Member

namusyaka commented Sep 13, 2013

Thank you, @matthias-guenther!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment