New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers documentation cleanup #1412

Merged
merged 17 commits into from Sep 15, 2013

Conversation

Projects
None yet
2 participants
@wikimatze
Member

wikimatze commented Sep 15, 2013

This time I run through all tests after making a git pull --rebase padrino master and they all passed.

@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze Sep 15, 2013

Member

Travis seems to have problems with with ruby 2.0 => what does AS_VERSION=3.1.0 means in this context?

Member

wikimatze commented Sep 15, 2013

Travis seems to have problems with with ruby 2.0 => what does AS_VERSION=3.1.0 means in this context?

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 15, 2013

Member

Thanks!
I guess that it means ActiveSupport version.
see: https://github.com/padrino/padrino-framework/blob/master/Gemfile#L5-L7

Member

namusyaka commented Sep 15, 2013

Thanks!
I guess that it means ActiveSupport version.
see: https://github.com/padrino/padrino-framework/blob/master/Gemfile#L5-L7

@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze Sep 15, 2013

Member

Thanks @namusyaka, you've opend my eyes. And the tests are now green, so ready for a merge.

Member

wikimatze commented Sep 15, 2013

Thanks @namusyaka, you've opend my eyes. And the tests are now green, so ready for a merge.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 15, 2013

Member

Yeah, looks good to me.
Thank you always for everything.

Member

namusyaka commented Sep 15, 2013

Yeah, looks good to me.
Thank you always for everything.

namusyaka added a commit that referenced this pull request Sep 15, 2013

Merge pull request #1412 from matthias-guenther/padrino-helpers-docum…
…entation-cleanup

Helpers documentation cleanup

@namusyaka namusyaka merged commit aa600a3 into padrino:master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details
@wikimatze

This comment has been minimized.

Show comment
Hide comment
@wikimatze

wikimatze Sep 15, 2013

Member

It's always a pleasure to clean up the code base and make it more beautiful. And thanks for let me learning the whole collaboration thing and the nice tips you and @ujifgc gave me.

Member

wikimatze commented Sep 15, 2013

It's always a pleasure to clean up the code base and make it more beautiful. And thanks for let me learning the whole collaboration thing and the nice tips you and @ujifgc gave me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment