New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailer documentation cleanup #1413

Merged
merged 5 commits into from Sep 15, 2013

Conversation

Projects
None yet
4 participants
@wikimatze
Member

wikimatze commented Sep 15, 2013

As usual: A documentation cleanup of the mailer component.

Cheers Matthias

ujifgc added a commit that referenced this pull request Sep 15, 2013

Merge pull request #1413 from matthias-guenther/padrino-mailer-docume…
…ntation-cleanup

Mailer documentation cleanup

@ujifgc ujifgc merged commit 2a860ac into padrino:master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details
@@ -42,6 +43,6 @@ def self.mime_type(mime, fallback=:plain)
"text/plain" => :plain,
"text/xml" => :xml
}
end # Mime
end # Mailer
end # Padrino

This comment has been minimized.

@dariocravero

dariocravero Sep 15, 2013

Contributor

Thanks for such a hard work @matthias-guenther! :) However, I'd still leave these kind of ending comments as they give you a hint of the section you were at. Thoughts @padrino/core-members?

@dariocravero

dariocravero Sep 15, 2013

Contributor

Thanks for such a hard work @matthias-guenther! :) However, I'd still leave these kind of ending comments as they give you a hint of the section you were at. Thoughts @padrino/core-members?

This comment has been minimized.

@ujifgc

ujifgc Sep 15, 2013

Member

I don't like these ending comments. If you're confused, what section you are, you should refactor.

@ujifgc

ujifgc Sep 15, 2013

Member

I don't like these ending comments. If you're confused, what section you are, you should refactor.

This comment has been minimized.

@wikimatze

wikimatze Sep 15, 2013

Member

I don't like them either - if you are using rubymine or vim for hacking, they have wonderful folding which makes it very easy to get an overview of the whole structure of the file.

@wikimatze

wikimatze Sep 15, 2013

Member

I don't like them either - if you are using rubymine or vim for hacking, they have wonderful folding which makes it very easy to get an overview of the whole structure of the file.

This comment has been minimized.

@dariocravero

dariocravero Sep 15, 2013

Contributor

I don't really add them to my day to day code. Just found them as a common practice throughout Padrino's code and thought they might have been useful for some other people. That's why I was asking :). Your point is valid though.

@dariocravero

dariocravero Sep 15, 2013

Contributor

I don't really add them to my day to day code. Just found them as a common practice throughout Padrino's code and thought they might have been useful for some other people. That's why I was asking :). Your point is valid though.

This comment has been minimized.

@wikimatze

wikimatze Sep 15, 2013

Member

Okay, then let's wait for the opinions of other persons. If there are more votes "Pro comments" I will add them again!

@wikimatze

wikimatze Sep 15, 2013

Member

Okay, then let's wait for the opinions of other persons. If there are more votes "Pro comments" I will add them again!

This comment has been minimized.

@namusyaka

namusyaka Sep 15, 2013

Member

End comments often help us, but these sometimes lead to verbose code.
I think these have merit and demerit.

@namusyaka

namusyaka Sep 15, 2013

Member

End comments often help us, but these sometimes lead to verbose code.
I think these have merit and demerit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment