New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop ruby 18mode, liberate ActiveSupport #1414

Merged
merged 3 commits into from Nov 15, 2013

Conversation

Projects
None yet
6 participants
@ujifgc
Member

ujifgc commented Sep 15, 2013

ref #1323

Are we there yet?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 15, 2013

Member

@padrino/core-members could someone remind me, why Travis separately tests against AS 3.1? Should we drop these tests?

Member

ujifgc commented Sep 15, 2013

@padrino/core-members could someone remind me, why Travis separately tests against AS 3.1? Should we drop these tests?

@ghost ghost assigned ujifgc Sep 15, 2013

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 15, 2013

Member

I think good timing.

Member

namusyaka commented Sep 15, 2013

I think good timing.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 15, 2013

Member

This probably has to be done in conjunction with bumping to 0.12.0 for the next release right? Is there anything we should wait on before pushing this into master (and doing a 0.12.0) release?

Member

nesquena commented Sep 15, 2013

This probably has to be done in conjunction with bumping to 0.12.0 for the next release right? Is there anything we should wait on before pushing this into master (and doing a 0.12.0) release?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 16, 2013

Member

Well, we have 2 blockers:
#1256 is virtually unfixable within current Tilt API and template naming
#863 should disappear with retiring http_router

Member

ujifgc commented Sep 16, 2013

Well, we have 2 blockers:
#1256 is virtually unfixable within current Tilt API and template naming
#863 should disappear with retiring http_router

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 18, 2013

Member

It's difficult for us to drop http_router at next release.
My router works only 2.0.0 at present.

Member

namusyaka commented Sep 18, 2013

It's difficult for us to drop http_router at next release.
My router works only 2.0.0 at present.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 18, 2013

Member

I think we can surely release 0.11.4 before that.

Member

ujifgc commented Sep 18, 2013

I think we can surely release 0.11.4 before that.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 22, 2013

Member

Yeah if you guys think it's wise, I will start preparing a 0.11.4 (for before we merge in this request) for release this week. @padrino/core-members ?

Member

nesquena commented Sep 22, 2013

Yeah if you guys think it's wise, I will start preparing a 0.11.4 (for before we merge in this request) for release this week. @padrino/core-members ?

@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Sep 22, 2013

Member

👍

Member

Ortuna commented Sep 22, 2013

👍

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Sep 22, 2013

Member

I think it's good. 👍

Member

namusyaka commented Sep 22, 2013

I think it's good. 👍

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 30, 2013

Member

This branch will be rebased a lot before 0.12 merge. Do not lean 😳

Member

ujifgc commented Sep 30, 2013

This branch will be rebased a lot before 0.12 merge. Do not lean 😳

ujifgc added a commit that referenced this pull request Nov 15, 2013

Merge pull request #1414 from padrino/19mode
drop ruby 18mode, liberate ActiveSupport

@ujifgc ujifgc merged commit 6a1acc6 into master Nov 15, 2013

1 check passed

default The Travis CI build passed
Details

@ujifgc ujifgc deleted the 19mode branch Nov 15, 2013

@dphase

This comment has been minimized.

Show comment
Hide comment
@dphase

dphase Nov 15, 2013

Is it not possible to accept both ActiveSupport 3 and 4? AFAIK, Mongoid 3 will not work alongside AR4, only Mongoid 4, which has not been officially released.

dphase commented Nov 15, 2013

Is it not possible to accept both ActiveSupport 3 and 4? AFAIK, Mongoid 3 will not work alongside AR4, only Mongoid 4, which has not been officially released.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Nov 16, 2013

Member

AFAIK, padrino does not rely on AS4 features, so that should be considered.

Member

skade commented Nov 16, 2013

AFAIK, padrino does not rely on AS4 features, so that should be considered.

ujifgc added a commit that referenced this pull request Nov 18, 2013

Ortuna added a commit to Ortuna/padrino-framework that referenced this pull request Jan 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment