New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padrino::Logger::Levels constants do not Severity from stdlib Logger class #1428

Merged
merged 1 commit into from Oct 2, 2013

Conversation

Projects
None yet
2 participants
@spariev
Contributor

spariev commented Oct 2, 2013

Not sure if it was done on purpose, but there is a mismatch between Logger::Severity constants (see http://rubydoc.info/stdlib/logger/Logger/Severity ) and constants in Padrino::Logger::Levels, which can lead to inconsitent results when using both loggers side by side, as I do.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 2, 2013

Member

Makes sense. 👍

Member

ujifgc commented Oct 2, 2013

Makes sense. 👍

ujifgc added a commit that referenced this pull request Oct 2, 2013

Merge pull request #1428 from spariev/patch-1
Padrino::Logger::Levels constants do not Severity from stdlib Logger class

@ujifgc ujifgc merged commit ba14365 into padrino:master Oct 2, 2013

1 check was pending

default The Travis CI build is in progress
Details

@spariev spariev deleted the spariev:patch-1 branch Oct 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment