New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reloader #1432

Merged
merged 19 commits into from Oct 6, 2013

Conversation

Projects
None yet
4 participants
@ujifgc
Member

ujifgc commented Oct 6, 2013

ref #1427

Largely refactored Reloader singleton, clarified a lot of cryptic code.

Summary of new behavior of Reloader:

  • will fail the application on SyntaxError
  • will log Exception details (class, message, first backtrace record)
  • will track I18n translation files of mounted applications
  • will successfully reload system features if they are required inside helpers

ujifgc added a commit that referenced this pull request Oct 6, 2013

@ujifgc ujifgc merged commit 3e0bf1b into master Oct 6, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@ujifgc ujifgc deleted the refactor-reloader branch Oct 6, 2013

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Oct 6, 2013

Contributor

@ujifgc this is amazing! :D Thanks so much for all the hard work here!! The new reloader kicks ass!..

Contributor

dariocravero commented Oct 6, 2013

@ujifgc this is amazing! :D Thanks so much for all the hard work here!! The new reloader kicks ass!..

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 6, 2013

Member

Thanks for your kind words! I wouldn't say it's the new reloader. It's the same one, just refactored and more honest. I'm confident it will be much less silent weird errors and confusion with reloading in development mode.

Member

ujifgc commented Oct 6, 2013

Thanks for your kind words! I wouldn't say it's the new reloader. It's the same one, just refactored and more honest. I'm confident it will be much less silent weird errors and confusion with reloading in development mode.

@ghost ghost assigned ujifgc Oct 6, 2013

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 6, 2013

Member

Amazing! Thanks a lot, that was a really big help!

Member

namusyaka commented Oct 6, 2013

Amazing! Thanks a lot, that was a really big help!

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Oct 6, 2013

Contributor

Well, you see @ujifgc, the fact that you fixed issues like locales not being reloaded or the weird helpers failing out of the blue already makes it amazing!.. :) Those changes are of huge help already!..

Contributor

dariocravero commented Oct 6, 2013

Well, you see @ujifgc, the fact that you fixed issues like locales not being reloaded or the weird helpers failing out of the blue already makes it amazing!.. :) Those changes are of huge help already!..

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 6, 2013

Member

Yep, a big step in the right direction in terms of less surprising behavior with the reloader.

Member

nesquena commented Oct 6, 2013

Yep, a big step in the right direction in terms of less surprising behavior with the reloader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment