New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken slim templates. #1435

Merged
merged 1 commit into from Oct 7, 2013

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Oct 7, 2013

This PR will solve #1434.
If merge this commit, both - and = are acceptable.
If using block in template, content_tag helper seems to concatenates content to temlate.

/cc @ujifgc @dariocravero

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 7, 2013

Member

How about haml?

Member

ujifgc commented Oct 7, 2013

How about haml?

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 7, 2013

Member

Is haml breaking?
I tried to haml. but I didn't see it.
First of all, haml has provided us with block_is_haml?.

Member

namusyaka commented Oct 7, 2013

Is haml breaking?
I tried to haml. but I didn't see it.
First of all, haml has provided us with block_is_haml?.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 7, 2013

Member

Okay!

Member

ujifgc commented Oct 7, 2013

Okay!

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 7, 2013

Member

Thanks.
I'll add the test cases to padrino-helpers.

Member

namusyaka commented Oct 7, 2013

Thanks.
I'll add the test cases to padrino-helpers.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 7, 2013

Member

I couldn't reproduce that case in test... But, the problem was solved by this commit.
Can I merge this commit?

Member

namusyaka commented Oct 7, 2013

I couldn't reproduce that case in test... But, the problem was solved by this commit.
Can I merge this commit?

ujifgc added a commit that referenced this pull request Oct 7, 2013

@ujifgc ujifgc merged commit 7b838f0 into padrino:master Oct 7, 2013

1 check passed

default The Travis CI build passed
Details

@namusyaka namusyaka deleted the namusyaka:fix-slim branch Oct 7, 2013

ujifgc added a commit that referenced this pull request Oct 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment