Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code cleanup #1448

Merged
merged 4 commits into from Oct 13, 2013
Merged

More code cleanup #1448

merged 4 commits into from Oct 13, 2013

Conversation

@ujifgc
Copy link
Member

ujifgc commented Oct 11, 2013

No description provided.

@namusyaka
Copy link
Member

namusyaka commented Oct 11, 2013

Great 👍

@dariocravero
Copy link
Contributor

dariocravero commented Oct 11, 2013

It looks amazing @ujifgc, thanks! There's an issue with the loading order though -libraries aren't loading right- that I'm debugging now but it looks like it's part of a previous commit. Will give more feedback in a while.
UPDATE: It's in d64144f.

dariocravero added a commit that referenced this pull request Oct 11, 2013
If we load apps first, libraries won't be there, hence throwing
exceptions at run time.
For example, this can be reproduced with any library that needs to be registered like ScssInitialiazer.
See #1448#issuecomment-26143346

Apps not being loaded at the last point makes things like libraries
ujifgc added a commit that referenced this pull request Oct 13, 2013
More code cleanup
@ujifgc ujifgc merged commit 66a66c7 into master Oct 13, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@ujifgc ujifgc deleted the cleanup-application branch Oct 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.