Allow padrino start to take handler specific options #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to pass options to the rack handler. For instance, with `puma` you can now do: `bundle exec padrino s -O Threads=3:16` and the server will start with 3 to 16 threads. This implementation follows the same syntax that [rackup](https://github.com/rack/rack/blob/master/lib/rack/server.rb\#L100) uses for compatibility. Also implemented --server_options to print out the supported options for the selected handler (application server). This has been requested a couple of times, the latest in #1451. I'd still recommend people to run their applications through the application server directly -e.g., puma, unicorn, thin...- instead of using this but it might come in handy for development.
| @@ -31,6 +31,7 @@ def self.start(app, opts={}) | |||
| FileUtils.mkdir_p(File.dirname(options[:pid])) | |||
| end | |||
| options[:server] = detect_rack_handler if options[:server].blank? | |||
| options.merge!(Hash[*options.delete(:options).map {|opt| opt.split('=',2)}.flatten].symbolize_keys!) if options[:options].is_a?(Array) | |||
There was a problem hiding this comment.
Might I suggest breaking this out into a few lines? Looks very intimidating at first glance.
There was a problem hiding this comment.
Yeah, that makes sense... they only question is how :) Maybe?:
if options[:options].is_a?(Array)
server_options = Hash[*options.delete(:options).map {|opt| opt.split('=',2)}.flatten].symbolize_keys!
options.merge!(server_options)
end
or
if options[:options].is_a?(Array)
parsed_server_options = options.delete(:options).map { |opt| opt.split('=', 2) }.flatten
server_options = Hash[*parsed_options].symbolize_keys!
options.merge!(server_options)
end
There was a problem hiding this comment.
if options[:options].is_a?(Array)
parsed_server_options = options.delete(:options).map { |opt| opt.split('=', 2) }.flatten
server_options = Hash[*parsed_options].symbolize_keys!
options.merge!(server_options)
end
👍
More than acceptable
|
👍 |
|
@Ortuna you can push to padrino-start-accepts-handler-options |
|
Done @Ortuna, thanks! :) |
ujifgc
added a commit
that referenced
this pull request
Oct 16, 2013
…ptions Allow padrino start to take handler specific options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
padrino startto take an extra--options(-O) parameter to pass options to the rack handler.For instance, with
pumayou can now do:bundle exec padrino s -O Threads=3:16and the server will start with 3 to 16 threads.This implementation follows the same syntax that rackup uses for compatibility.
Also implemented --server_options to print out the supported options for the selected handler (application server).
This has been requested a couple of times, the latest in #1451.
I'd still recommend people to run their applications through the application server directly -e.g., puma, unicorn, thin...- instead of using this but it might come in handy for development.
Thoughts @padrino/core-members?