New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow padrino start to take handler specific options #1452

Merged
merged 2 commits into from Oct 16, 2013

Conversation

Projects
None yet
3 participants
@dariocravero
Contributor

dariocravero commented Oct 14, 2013

Modified padrino start to take an extra --options (-O) parameter to pass options to the rack handler.

For instance, with puma you can now do:
bundle exec padrino s -O Threads=3:16 and the server will start with 3 to 16 threads.

This implementation follows the same syntax that rackup uses for compatibility.

Also implemented --server_options to print out the supported options for the selected handler (application server).

This has been requested a couple of times, the latest in #1451.

I'd still recommend people to run their applications through the application server directly -e.g., puma, unicorn, thin...- instead of using this but it might come in handy for development.

Thoughts @padrino/core-members?

Modified `padrino start` to take an extra `--options` (`-O`) parameter
to pass options to the rack handler.

For instance, with `puma` you can now do:
`bundle exec padrino s -O Threads=3:16` and the server will start with 3
to 16 threads.

This implementation follows the same syntax that
[rackup](https://github.com/rack/rack/blob/master/lib/rack/server.rb\#L100) uses for
compatibility.

Also implemented --server_options to print out the supported options for
the selected handler (application server).

This has been requested a couple of times, the latest in #1451.

I'd still recommend people to run their applications through the
application server directly -e.g., puma, unicorn, thin...- instead of
using this but it might come in handy for development.
@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Oct 14, 2013

Member

👍

Member

Ortuna commented Oct 14, 2013

👍

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 15, 2013

Member

@Ortuna you can push to padrino-start-accepts-handler-options

Member

ujifgc commented Oct 15, 2013

@Ortuna you can push to padrino-start-accepts-handler-options

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Oct 15, 2013

Contributor

Done @Ortuna, thanks! :)

Contributor

dariocravero commented Oct 15, 2013

Done @Ortuna, thanks! :)

ujifgc added a commit that referenced this pull request Oct 16, 2013

Merge pull request #1452 from padrino/padrino-start-accepts-handler-o…
…ptions

Allow padrino start to take handler specific options

@ujifgc ujifgc merged commit 3c80cac into master Oct 16, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@ujifgc ujifgc deleted the padrino-start-accepts-handler-options branch Oct 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment