Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1405 params hash keys #1470

Merged
merged 1 commit into from Oct 23, 2013
Merged

#1405 params hash keys #1470

merged 1 commit into from Oct 23, 2013

Conversation

Ortuna
Copy link
Member

@Ortuna Ortuna commented Oct 18, 2013

Fixes #1405.

Only breaking change seems to be the to_s prints out keys as quoted strings as opposed to symbolized.

@Ortuna
Copy link
Member Author

Ortuna commented Oct 18, 2013

It needs some work, I'll get a fully working version going(need to test POST params too)

@nesquena
Copy link
Member

nesquena commented Oct 18, 2013

OK, at the moment looks like the format handling might have been broken by using HashWithIndifferentAccess (just based on what I was seeing in Travis, but only for 1.8.7) and we won't be supporting that much longer

- the `params` variable is converted into a HashWithIndifferentAccess
  object
- fixes #1405
@namusyaka
Copy link
Contributor

namusyaka commented Oct 21, 2013

Great 👍

Ortuna added a commit that referenced this pull request Oct 23, 2013
@Ortuna Ortuna merged commit c987037 into master Oct 23, 2013
@Ortuna Ortuna deleted the issue-1405-param-hash branch Oct 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

params hash keys
3 participants