#1405 params hash keys #1470

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
3 participants
@Ortuna
Member

Ortuna commented Oct 18, 2013

Fixes #1405.

Only breaking change seems to be the to_s prints out keys as quoted strings as opposed to symbolized.

@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Oct 18, 2013

Member

It needs some work, I'll get a fully working version going(need to test POST params too)

Member

Ortuna commented Oct 18, 2013

It needs some work, I'll get a fully working version going(need to test POST params too)

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 18, 2013

Member

OK, at the moment looks like the format handling might have been broken by using HashWithIndifferentAccess (just based on what I was seeing in Travis, but only for 1.8.7) and we won't be supporting that much longer

Member

nesquena commented Oct 18, 2013

OK, at the moment looks like the format handling might have been broken by using HashWithIndifferentAccess (just based on what I was seeing in Travis, but only for 1.8.7) and we won't be supporting that much longer

issue #1405 - params hash keys
- the `params` variable is converted into a HashWithIndifferentAccess
  object
- fixes #1405
@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 21, 2013

Member

Great 👍

Member

namusyaka commented Oct 21, 2013

Great 👍

Ortuna added a commit that referenced this pull request Oct 23, 2013

@Ortuna Ortuna merged commit c987037 into master Oct 23, 2013

1 check passed

default The Travis CI build passed
Details

@Ortuna Ortuna deleted the issue-1405-param-hash branch Oct 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment