New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting logic to methods to improve readability #1513

Merged
merged 3 commits into from Dec 11, 2013

Conversation

Projects
None yet
3 participants
@scudelletti
Contributor

scudelletti commented Dec 11, 2013

Guys I was reading the code and I thought about some changes in setup_csrf_protection method.

I don't know the indentation and stye of code that you guys use, so tell me if I made something wrong.

This PR includes 2 changes:

  • Fixed a typo error
  • Removed the nested if from setup_csrf_protection
  • Refactored setup_csrf_protection method to keep it smaller

✌️ Peace on Earth ✌️

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Dec 11, 2013

Member

Looks good to me! 👍

Member

DAddYE commented Dec 11, 2013

Looks good to me! 👍

@Ortuna

This comment has been minimized.

Show comment
Hide comment
@Ortuna

Ortuna Dec 11, 2013

Member

👍 Thanks!

Member

Ortuna commented Dec 11, 2013

👍 Thanks!

Ortuna added a commit that referenced this pull request Dec 11, 2013

Merge pull request #1513 from scudelletti/ds-padrino
Extracting logic to methods to improve readability

@Ortuna Ortuna merged commit 8c98aee into padrino:master Dec 11, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment