New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem the before/after filters don't work when they are inserted after the target route in controller. #1555

Merged
merged 2 commits into from Jan 16, 2014

Conversation

Projects
None yet
3 participants
@namusyaka
Member

namusyaka commented Jan 15, 2014

The before/after filters don't work when they are inserted after the target route in controller.

Edge::App.controllers :test do
  get(:index){ @foo }
  before(:index){ @foo = "Hello World" }
end

get "/test/" #=> Expected: "Hello World", Actual: ""
Show outdated Hide outdated padrino-core/test/test_routing.rb Outdated
@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 16, 2014

Member

This looks good to me.

Member

skade commented Jan 16, 2014

This looks good to me.

skade added a commit that referenced this pull request Jan 16, 2014

Merge pull request #1555 from padrino/fix-filters
Fix a problem the before/after filters don't work when they are inserted after the target route in controller.

@skade skade merged commit 6a99189 into master Jan 16, 2014

1 check passed

default The Travis CI build passed
Details

@namusyaka namusyaka deleted the fix-filters branch Jan 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment